Re: [PATCH 3/4] scsi: mpi3mr: struct mpi3_sas_io_unit_page0: Replace 1-element array with flexible array

[Gustavo A. R. Silva]

On 11/07/24 09:56, Kees Cook wrote:
> Replace the deprecated[1] use of a 1-element array in
> struct mpi3_sas_io_unit_page0 with a modern flexible array.
>
> No binary differences are present after this conversion.
>
> Link: https://github.com/KSPP/linux/issues/79 [1]
> Signed-off-by: Kees Cook <kees@xxxxxxxxxx>

Reviewed-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>

Thanks
--
Gustavo

> ---
> Cc: Sathya Prakash Veerichetty <sathya.prakash@xxxxxxxxxxxx>
> Cc: Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>
> Cc: Sumit Saxena <sumit.saxena@xxxxxxxxxxxx>
> Cc: Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx>
> Cc: "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
> Cc: Ranjan Kumar <ranjan.kumar@xxxxxxxxxxxx>
> Cc: mpi3mr-linuxdrv.pdl@xxxxxxxxxxxx
> Cc: linux-scsi@xxxxxxxxxxxxxxx
> ---
>   drivers/scsi/mpi3mr/mpi/mpi30_cnfg.h | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/mpi3mr/mpi/mpi30_cnfg.h b/drivers/scsi/mpi3mr/mpi/mpi30_cnfg.h
> index 6a19e17eb1a7..66cca35d8e52 100644
> --- a/drivers/scsi/mpi3mr/mpi/mpi30_cnfg.h
> +++ b/drivers/scsi/mpi3mr/mpi/mpi30_cnfg.h
> @@ -1565,16 +1565,13 @@ struct mpi3_sas_io_unit0_phy_data {
>   	__le32             reserved10;
>   };
>   
> -#ifndef MPI3_SAS_IO_UNIT0_PHY_MAX
> -#define MPI3_SAS_IO_UNIT0_PHY_MAX           (1)
> -#endif
>   struct mpi3_sas_io_unit_page0 {
>   	struct mpi3_config_page_header         header;
>   	__le32                             reserved08;
>   	u8                                 num_phys;
>   	u8                                 init_status;
>   	__le16                             reserved0e;
> -	struct mpi3_sas_io_unit0_phy_data      phy_data[MPI3_SAS_IO_UNIT0_PHY_MAX];
> +	struct mpi3_sas_io_unit0_phy_data      phy_data[];
>   };
>   
>   #define MPI3_SASIOUNIT0_PAGEVERSION                          (0x00)