Re: [PATCH] selftests/bpf:fix a resource leak in main()

[Stanislav Fomichev]

On 07/11, Ma Ke wrote:
> The requested resources should be closed before return in main(), otherwise
>  resource leak will occur. Add a check of cg_fd before close().
> 
> Fixes: 435f90a338ae ("selftests/bpf: add a test case for sock_ops perf-event notification")
> Signed-off-by: Ma Ke <make24@xxxxxxxxxxx>
> ---
>  tools/testing/selftests/bpf/test_tcpnotify_user.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/test_tcpnotify_user.c b/tools/testing/selftests/bpf/test_tcpnotify_user.c
> index 595194453ff8..f81c60db586e 100644
> --- a/tools/testing/selftests/bpf/test_tcpnotify_user.c
> +++ b/tools/testing/selftests/bpf/test_tcpnotify_user.c
> @@ -161,7 +161,8 @@ int main(int argc, char **argv)
>  	error = 0;
>  err:
>  	bpf_prog_detach(cg_fd, BPF_CGROUP_SOCK_OPS);
> -	close(cg_fd);

Worst case that happens here is that we call close(-1) which returns
EBADFS or something similar. Don't think there is any problem. This
applies to the rest of that patches that add an extra 'if' check.