Re: [PATCH net-next 3/3] net: netconsole: Disable target before netpoll cleanup

From: Jakub Kicinski
Date: Thu Jul 11 2024 - 21:32:35 EST


On Tue, 9 Jul 2024 07:44:01 -0700 Breno Leitao wrote:
> Currently, netconsole cleans up the netpoll structure before disabling
> the target. This approach can lead to race conditions, as message
> senders (write_ext_msg() and write_msg()) check if the target is
> enabled before using netpoll.
>
> This patch reverses the order of operations:
> 1. Disable the target
> 2. Clean up the netpoll structure
>
> This change eliminates the potential race condition, ensuring that
> no messages are sent through a partially cleaned-up netpoll structure.

I think this is a legit fix, please add a Fixes tag and resend for net.