Re: [PATCH 3/3] mm: shmem: move shmem_huge_global_enabled() into shmem_allowable_huge_orders()
From: kernel test robot
Date: Fri Jul 12 2024 - 00:28:15 EST
Hi Baolin,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on next-20240711]
[cannot apply to linus/master v6.10-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Baolin-Wang/mm-shmem-simplify-the-suitable-huge-orders-validation-for-tmpfs/20240711-134512
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/6e5858d345304d0428c1c2c2a25c289c062b4ea8.1720668581.git.baolin.wang%40linux.alibaba.com
patch subject: [PATCH 3/3] mm: shmem: move shmem_huge_global_enabled() into shmem_allowable_huge_orders()
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20240712/202407121206.GWdo7NlT-lkp@xxxxxxxxx/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240712/202407121206.GWdo7NlT-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407121206.GWdo7NlT-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
mm/shmem.c: In function 'shmem_getattr':
>> mm/shmem.c:1160:13: error: implicit declaration of function 'shmem_huge_global_enabled' [-Werror=implicit-function-declaration]
1160 | if (shmem_huge_global_enabled(inode, 0, false, NULL, 0))
| ^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/shmem_huge_global_enabled +1160 mm/shmem.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1138
b74d24f7a74ffd Christian Brauner 2023-01-13 1139 static int shmem_getattr(struct mnt_idmap *idmap,
549c7297717c32 Christian Brauner 2021-01-21 1140 const struct path *path, struct kstat *stat,
a528d35e8bfcc5 David Howells 2017-01-31 1141 u32 request_mask, unsigned int query_flags)
44a30220bc0a17 Yu Zhao 2015-09-08 1142 {
a528d35e8bfcc5 David Howells 2017-01-31 1143 struct inode *inode = path->dentry->d_inode;
44a30220bc0a17 Yu Zhao 2015-09-08 1144 struct shmem_inode_info *info = SHMEM_I(inode);
44a30220bc0a17 Yu Zhao 2015-09-08 1145
3c1b7528d8969a Hugh Dickins 2023-08-03 1146 if (info->alloced - info->swapped != inode->i_mapping->nrpages)
3c1b7528d8969a Hugh Dickins 2023-08-03 1147 shmem_recalc_inode(inode, 0, 0);
3c1b7528d8969a Hugh Dickins 2023-08-03 1148
e408e695f5f1f6 Theodore Ts'o 2022-07-14 1149 if (info->fsflags & FS_APPEND_FL)
e408e695f5f1f6 Theodore Ts'o 2022-07-14 1150 stat->attributes |= STATX_ATTR_APPEND;
e408e695f5f1f6 Theodore Ts'o 2022-07-14 1151 if (info->fsflags & FS_IMMUTABLE_FL)
e408e695f5f1f6 Theodore Ts'o 2022-07-14 1152 stat->attributes |= STATX_ATTR_IMMUTABLE;
e408e695f5f1f6 Theodore Ts'o 2022-07-14 1153 if (info->fsflags & FS_NODUMP_FL)
e408e695f5f1f6 Theodore Ts'o 2022-07-14 1154 stat->attributes |= STATX_ATTR_NODUMP;
e408e695f5f1f6 Theodore Ts'o 2022-07-14 1155 stat->attributes_mask |= (STATX_ATTR_APPEND |
e408e695f5f1f6 Theodore Ts'o 2022-07-14 1156 STATX_ATTR_IMMUTABLE |
e408e695f5f1f6 Theodore Ts'o 2022-07-14 1157 STATX_ATTR_NODUMP);
0d72b92883c651 Jeff Layton 2023-08-07 1158 generic_fillattr(idmap, request_mask, inode, stat);
89fdcd262fd407 Yang Shi 2018-06-07 1159
dca7b12ffe751b Baolin Wang 2024-07-11 @1160 if (shmem_huge_global_enabled(inode, 0, false, NULL, 0))
89fdcd262fd407 Yang Shi 2018-06-07 1161 stat->blksize = HPAGE_PMD_SIZE;
89fdcd262fd407 Yang Shi 2018-06-07 1162
f7cd16a55837f3 Xavier Roche 2022-03-22 1163 if (request_mask & STATX_BTIME) {
f7cd16a55837f3 Xavier Roche 2022-03-22 1164 stat->result_mask |= STATX_BTIME;
f7cd16a55837f3 Xavier Roche 2022-03-22 1165 stat->btime.tv_sec = info->i_crtime.tv_sec;
f7cd16a55837f3 Xavier Roche 2022-03-22 1166 stat->btime.tv_nsec = info->i_crtime.tv_nsec;
f7cd16a55837f3 Xavier Roche 2022-03-22 1167 }
f7cd16a55837f3 Xavier Roche 2022-03-22 1168
44a30220bc0a17 Yu Zhao 2015-09-08 1169 return 0;
44a30220bc0a17 Yu Zhao 2015-09-08 1170 }
44a30220bc0a17 Yu Zhao 2015-09-08 1171
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki