RE: [PATCH] vfio-mdev: add MODULE_DESCRIPTION() macros

[Kirti Wankhede]

+ Alex.

Reviewed by : Kirti Wankhede <kwankhede@xxxxxxxxxx>


> -----Original Message-----
> From: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> Sent: Friday, July 12, 2024 12:01 AM
> To: Kirti Wankhede <kwankhede@xxxxxxxxxx>
> Cc: kvm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kernel-
> janitors@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] vfio-mdev: add MODULE_DESCRIPTION() macros
> 
> On 5/23/24 17:12, Jeff Johnson wrote:
> > Fix the 'make W=1' warnings:
> > WARNING: modpost: missing MODULE_DESCRIPTION() in samples/vfio-
> mdev/mtty.o
> > WARNING: modpost: missing MODULE_DESCRIPTION() in samples/vfio-
> mdev/mdpy.o
> > WARNING: modpost: missing MODULE_DESCRIPTION() in samples/vfio-
> mdev/mdpy-fb.o
> > WARNING: modpost: missing MODULE_DESCRIPTION() in samples/vfio-
> mdev/mbochs.o
> >
> > Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> > ---
> >   samples/vfio-mdev/mbochs.c  | 1 +
> >   samples/vfio-mdev/mdpy-fb.c | 1 +
> >   samples/vfio-mdev/mdpy.c    | 1 +
> >   samples/vfio-mdev/mtty.c    | 1 +
> >   4 files changed, 4 insertions(+)
> >
> > diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c
> > index 9062598ea03d..836456837997 100644
> > --- a/samples/vfio-mdev/mbochs.c
> > +++ b/samples/vfio-mdev/mbochs.c
> > @@ -88,6 +88,7 @@
> >   #define STORE_LE32(addr, val)	(*(u32 *)addr = val)
> >
> >
> > +MODULE_DESCRIPTION("Mediated virtual PCI display host device driver");
> >   MODULE_LICENSE("GPL v2");
> >
> >   static int max_mbytes = 256;
> > diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c
> > index 4598bc28acd9..149af7f598f8 100644
> > --- a/samples/vfio-mdev/mdpy-fb.c
> > +++ b/samples/vfio-mdev/mdpy-fb.c
> > @@ -229,4 +229,5 @@ static int __init mdpy_fb_init(void)
> >   module_init(mdpy_fb_init);
> >
> >   MODULE_DEVICE_TABLE(pci, mdpy_fb_pci_table);
> > +MODULE_DESCRIPTION("Framebuffer driver for mdpy (mediated virtual pci
> display device)");
> >   MODULE_LICENSE("GPL v2");
> > diff --git a/samples/vfio-mdev/mdpy.c b/samples/vfio-mdev/mdpy.c
> > index 27795501de6e..8104831ae125 100644
> > --- a/samples/vfio-mdev/mdpy.c
> > +++ b/samples/vfio-mdev/mdpy.c
> > @@ -40,6 +40,7 @@
> >   #define STORE_LE32(addr, val)	(*(u32 *)addr = val)
> >
> >
> > +MODULE_DESCRIPTION("Mediated virtual PCI display host device driver");
> >   MODULE_LICENSE("GPL v2");
> >
> >   #define MDPY_TYPE_1 "vga"
> > diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> > index 2284b3751240..40e7d154455e 100644
> > --- a/samples/vfio-mdev/mtty.c
> > +++ b/samples/vfio-mdev/mtty.c
> > @@ -2059,5 +2059,6 @@ module_exit(mtty_dev_exit)
> >
> >   MODULE_LICENSE("GPL v2");
> >   MODULE_INFO(supported, "Test driver that simulate serial port over PCI");
> > +MODULE_DESCRIPTION("Test driver that simulate serial port over PCI");
> >   MODULE_VERSION(VERSION_STRING);
> >   MODULE_AUTHOR(DRIVER_AUTHOR);
> >
> > ---
> > base-commit: 5c4069234f68372e80e4edfcce260e81fd9da007
> > change-id: 20240523-md-vfio-mdev-381f74bf87f1
> >
> 
> I don't see this in linux-next yet so following up to see if anything
> else is needed to get this merged.
> 
> I hope to have these warnings fixed tree-wide in 6.11.
> 
> /jeff