[PATCH 2/2] selftests: x86: vdso_restorer: Return correct exit statuses
From: Muhammad Usama Anjum
Date: Fri Jul 12 2024 - 03:31:29 EST
Return correct exit status, KSFT_SKIP if the pre-conditions aren't met.
Return KSFT_FAIL if error occurs. Use ksft_finished() which will
compmare the total planned tests with passed tests to return the exit
value.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
---
tools/testing/selftests/x86/vdso_restorer.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/x86/vdso_restorer.c b/tools/testing/selftests/x86/vdso_restorer.c
index 8e173d71291f6..54f33e8cda5cc 100644
--- a/tools/testing/selftests/x86/vdso_restorer.c
+++ b/tools/testing/selftests/x86/vdso_restorer.c
@@ -56,7 +56,7 @@ int main()
RTLD_LAZY | RTLD_LOCAL | RTLD_NOLOAD);
if (!vdso) {
printf("[SKIP]\tFailed to find vDSO. Tests are not expected to work.\n");
- return 0;
+ return KSFT_SKIP;
}
ksft_set_plan(2);
@@ -69,7 +69,7 @@ int main()
printf("[RUN]\tRaise a signal, SA_SIGINFO, sa.restorer == NULL\n");
if (syscall(SYS_rt_sigaction, SIGUSR1, &sa, NULL, 8) != 0)
- err(1, "raw rt_sigaction syscall");
+ err(KSFT_FAIL, "raw rt_sigaction syscall");
raise(SIGUSR1);
@@ -80,10 +80,12 @@ int main()
sa.flags = 0;
sa.handler = handler_without_siginfo;
if (syscall(SYS_sigaction, SIGUSR1, &sa, 0) != 0)
- err(1, "raw sigaction syscall");
+ err(KSFT_FAIL, "raw sigaction syscall");
handler_called = 0;
raise(SIGUSR1);
ksft_test_result(handler_called, "SA_SIGINFO handler returned\n");
+
+ ksft_finished();
}
--
2.39.2