Re: [PATCH 2/5] arm64: dts: amlogic: s4: add ao secure node

From: Krzysztof Kozlowski
Date: Fri Jul 12 2024 - 03:50:41 EST


On 12/07/2024 08:54, Xianwei Zhao via B4 Relay wrote:
> From: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx>
>
> Add node for board info registers, which allows getting SoC family and
> board revision.
>
> For example, with MESON_GX_SOCINFO config enabled we can get the
> following information for board with Amlogic S4 SoC:
> soc soc0: Amlogic S4 (S805X2) Revision 37:a (2:1) Detecte
>
> Signed-off-by: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> index c11c947fa18c..316905ec191c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> @@ -763,6 +763,12 @@ reset: reset-controller@2000 {
> #reset-cells = <1>;
> };
>
> + sec_ao: ao-secure@10220 {
> + compatible = "amlogic,meson-gx-ao-secure", "syscon";

This is not gx, but s4, so incorrect compatible used. Same for all other
patches.

Best regards,
Krzysztof