Re: [PATCH 01/17] syscalls: add generic scripts/syscall.tbl

[Masahiro Yamada]

On Thu, Jul 4, 2024 at 11:36 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The asm-generic/unistd.h header still follows the old style of defining
> system call numbers and the table. Most architectures got the new
> syscall.tbl format as part of the y2038 conversion back in 2018, but
> the newer architectures that share a single table never did.
>
> I did a semi-automated conversion of the asm-generic/unistd.h contents
> into a syscall.tbl format, using the ABI field to take care of all
> the relevant differences that are encoded using #ifdef checks in the
> existing header.
>
> Conversion of the architectures is done one at a time in order to
> be able to review or revert them as needed.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---



> +65     common  readv                           sys_readv                       sys_readv
> +66     common  writev                          sys_writev                      sys_writev


Nit.


I know this is already written in this way
in include/uapi/asm-generic/unistd.h, but
the native and compat have the same function name.


Can we simplify it like this?

65     common  readv                           sys_readv
66     common  writev                          sys_writev






--
Best Regards
Masahiro Yamada