Re: [EXTERNAL] Re: [PATCH v10 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K DPI administrative driver

From: Greg KH
Date: Fri Jul 12 2024 - 04:55:27 EST


On Fri, Jul 12, 2024 at 08:44:22AM +0000, Vamsi Krishna Attunuru wrote:
>
> >> >> >>
> >> >> >> +config MARVELL_CN10K_DPI
> >> >> >> + tristate "Octeon CN10K DPI driver"
> >> >> >> + depends on ARM64 && PCI
> >> >> >
> >> >> >Why does ARM64 matter here? I don't see any dependency required
> >of it.
> >> >> >
> >> >> Thanks, Greg, for your time. This DPI device is an on-chip PCIe
> >> >> device and only present on Marvell's CN10K platforms(which are
> >> >> 64-bit ARM SoC
> >> >processors), so added those dependency.
> >> >
> >> >Then perhaps keep the ARM64 and add a COMPILE_TEST option as well so
> >> >that we can build this as part of normal testing?
> >> >
> >> >So that would be:
> >> > depends on PCI && (ARM64 || COMPILE_TEST) right?
> >> >
> >> Yes, it makes sense to add. Can I send this fix as next version now so
> >> that it will show up in next release, please suggest.
> >
> >Send it as a follow-on patch on top of my tree, doing what Arnd suggested.
>
> Hi Greg, I submitted the follow-on patch on top of your char-misc-testing.
> Please let me know if there is any additional action required on my part.

Just now applied, this crossed in the email ether.

greg k-h