Re: [PATCH V2 3/5] Add aw9610x series related interfaces to the aw_sar driver

[wangshuaijie]

Hi Krzysztof,

On Wed, 5 Jun 2024 12:22:16, krzk@xxxxxxxxxx wrote:
>On 05/06/2024 11:11, wangshuaijie@xxxxxxxxxx wrote:
>> From: shuaijie wang <wangshuaijie@xxxxxxxxxx>
>> 
>
>No commit msg, no proper subject prefix.
>

The patch for v3 will fix these issues.

>> Signed-off-by: shuaijie wang <wangshuaijie@xxxxxxxxxx>
>> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
>> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>> | Reported-by: Dan Carpenter <error27@xxxxxxxxx>
>
>Drop all these, this is some bogus tags. Tag never starts with pipe, btw.
>

The patch for v3 will fix these issues.

>> ---
>>  drivers/input/misc/aw_sar/aw9610x/aw9610x.c | 884 ++++++++++++++++++++
>>  drivers/input/misc/aw_sar/aw9610x/aw9610x.h | 327 ++++++++
>>  2 files changed, 1211 insertions(+)
>>  create mode 100644 drivers/input/misc/aw_sar/aw9610x/aw9610x.c
>>  create mode 100644 drivers/input/misc/aw_sar/aw9610x/aw9610x.h
>
>...
>
>> +struct aw_reg_data {
>> +	unsigned char rw;
>> +	unsigned short reg;
>> +};
>> +/********************************************
>> + * Register Access
>> + *******************************************/
>> +#define REG_NONE_ACCESS					(0)
>> +#define REG_RD_ACCESS					(1 << 0)
>> +#define REG_WR_ACCESS					(1 << 1)
>> +
>> +static const struct aw_reg_data g_aw9610x_reg_access[] = {
>
>Ehh... so we are at basics of C. Data structures do not go to headers.
>

The patch for v3 will fix these issues.

>
>Best regards,
>Krzysztof

Kind regards,
Wang Shuaijie