Re: [PATCH v2] drivers/clocksource/qcom: Add missing iounmap() on errors in msm_dt_timer_init() function.

From: Konrad Dybcio
Date: Fri Jul 12 2024 - 05:55:13 EST


On 12.07.2024 11:51 AM, Konrad Dybcio wrote:
> On 12.07.2024 10:27 AM, Ankit Agrawal wrote:
>> Add the missing iounmap() when clock frequency fails to get read by the
>> of_property_read_u32() call, or if the call to msm_timer_init() fails.
>>
>> Signed-off-by: Ankit Agrawal <agrawal.ag.ankit@xxxxxxxxx>
>> ---
>
> For your future submissions: run:
>
> /scripts/checkpatch.pl -g $(git describe --abbrev=0)..
>
> to run some static checks, such as "title is rather long"
>
>
> ..but I don't mind!
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Also:

Fixes: 6e3321631ac2 ("ARM: msm: Add DT support to msm_timer")

Konrad