Re: [PATCH] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

From: Dmitry Baryshkov
Date: Fri Jul 12 2024 - 06:26:57 EST


On Thu, 11 Jul 2024 at 17:32, Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
>
> The Lenovo Yoga C630 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Lenovo Yoga C630 laptop. Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
>
> Fixes: 5e5f2f92cccc29f3 ("platform: arm64: add Lenovo Yoga C630 WOS EC driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> drivers/platform/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Could you please add the same condition to the Acer Aspire 1 entry?

>
> diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
> index 058a4baa216a83b8..f7539e5419cf1616 100644
> --- a/drivers/platform/arm64/Kconfig
> +++ b/drivers/platform/arm64/Kconfig
> @@ -35,6 +35,7 @@ config EC_ACER_ASPIRE1
>
> config EC_LENOVO_YOGA_C630
> tristate "Lenovo Yoga C630 Embedded Controller driver"
> + depends on ARCH_QCOM || COMPILE_TEST
> depends on I2C
> select AUXILIARY_BUS
> help
> --
> 2.34.1
>


--
With best wishes
Dmitry