Re: [PATCH net-next v2] net: ti: icssg-prueth: Split out common object into module

[MD Danish Anwar]

On 12/07/24 4:42 pm, Thorsten Leemhuis wrote:
> On 26.06.24 09:19, Thorsten Leemhuis wrote:
>> On 06.06.24 17:54, Andrew Lunn wrote:
>>>> +EXPORT_SYMBOL_GPL(icssg_class_set_mac_addr);
>>>> +EXPORT_SYMBOL_GPL(icssg_class_disable);
>>>> +EXPORT_SYMBOL_GPL(icssg_class_default);
>>>> +EXPORT_SYMBOL_GPL(icssg_class_promiscuous_sr1);
>>> [...]
>>> Please could you clean up the namespace a little. icssg_ and prueth_
>>> are O.K, but we also have arc/emac_rockchip.c, allwinner/sun4i-emac.c,
>>> ibm/emac/, and qualcomm/emac/ using the emac_ prefix.
>>
>> Just wondering (not as a regression tracker, just as someone that ran
>> into this and carries the patch in his tree to avoid a build error for
>> next):
>>
>> What happened to this fix? After above feedback nearly 20 days ago
>> nothing happened afaics. Did this fall through the cracks? Or was some
>> other solution found and I just missed this (and thus can drop the fix
>> from my tree)?
> 
> That inquiry lead to a review from Roger (thx!) more than two weeks ago,
> but that was all afaics. Makes me wonder if this regression will hit
> mainline soon, as the merge window might open on Monday already.
> 
> Ciao, Thorsten


Andrew L has given comment to clean up the API names. I will rename the
APIs being exported from emac_ prefix to icssg_ prefix and re-spin this.

-- 
Thanks and Regards,
Danish