Re: [PATCH 1/1] iommufd: Fix error pointer checking

From: Jason Gunthorpe
Date: Fri Jul 12 2024 - 08:52:40 EST


On Fri, Jul 12, 2024 at 10:58:19AM +0800, Lu Baolu wrote:
> Smatch static checker reported below warning:
>
> drivers/iommu/iommufd/fault.c:131 iommufd_device_get_attach_handle()
> warn: 'handle' is an error pointer or valid
>
> Fix it by checking 'handle' with IS_ERR().
>
> Fixes: b7d8833677ba ("iommufd: Fault-capable hwpt attach/detach/replace")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-iommu/8bb4f37a-4514-4dea-aabb-7380be303895@stanley.mountain/
> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> ---
> drivers/iommu/iommufd/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied

Thanks,
Jason