[PATCH net-next] bnx2x: turn off FCoE if storage MAC-address setup failed

From: Nikita Kiryushin
Date: Fri Jul 12 2024 - 09:29:44 EST


As of now, initial storage MAC setup (in bnx2x_init_one) is not checked.

This can lead to unexpected FCoE behavior (as address will be in unexpected
state) without notice.

Check dev_addr_add for storage MAC and if it failes produce error message
and turn off FCoE feature.

Signed-off-by: Nikita Kiryushin <kiryushin@xxxxxxxx>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 678829646cec..c5d5e85777d4 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -13988,8 +13988,12 @@ static int bnx2x_init_one(struct pci_dev *pdev,
if (!NO_FCOE(bp)) {
/* Add storage MAC address */
rtnl_lock();
- dev_addr_add(bp->dev, bp->fip_mac, NETDEV_HW_ADDR_T_SAN);
+ rc = dev_addr_add(bp->dev, bp->fip_mac, NETDEV_HW_ADDR_T_SAN);
rtnl_unlock();
+ if (rc) {
+ dev_err(&pdev->dev, "Cannot add storage MAC address\n");
+ bp->flags |= NO_FCOE_FLAG;
+ }
}
BNX2X_DEV_INFO(
"%s (%c%d) PCI-E found at mem %lx, IRQ %d, node addr %pM\n",
--
2.34.1