Re: next-20240712: task_work.c:(.text+0xc2): undefined reference to `irq_work_queue'
From: Peter Zijlstra
Date: Fri Jul 12 2024 - 11:03:43 EST
On Fri, Jul 12, 2024 at 04:11:54PM +0200, Arnd Bergmann wrote:
> On Fri, Jul 12, 2024, at 15:24, Peter Zijlstra wrote:
> > On Fri, Jul 12, 2024 at 02:28:38PM +0200, Arnd Bergmann wrote:
> >> On Fri, Jul 12, 2024, at 14:13, Naresh Kamboju wrote:
> >
> >> that we may have to always enable IRQ_WORK even on non-SMP
> >> kernels now. In practice it is already enabled in most
> >> configurations for one reason or another, the the cost is
> >> likely very small.
> >>
> >> Otherwise checking for CONFIG_HAVE_NMI in the new code might work.
> >
> > ARM seems to have HAVE_NMI while also being one of the architectures
> > that is now failing.
>
> Right, in this case we would also need
>
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -236,6 +236,7 @@ config HAVE_FUNCTION_ERROR_INJECTION
>
> config HAVE_NMI
> bool
> + select IRQ_WORK
>
> config HAVE_FUNCTION_DESCRIPTORS
> bool
Yeah, that works for me I suppose.