Re: [PATCH net-next v2 1/1] net: phy: dp83td510: add cable testing support

[Andrew Lunn]

On Fri, Jul 12, 2024 at 05:28:48PM +0200, Oleksij Rempel wrote:
> This patch implements the TDR test procedure as described in
> "Application Note DP83TD510E Cable Diagnostics Toolkit revC", section 3.2.
> 
> The procedure was tested with "draka 08 signalkabel 2x0.8mm". The reported
> cable length was 5 meters more for each 20 meters of actual cable length.
> For instance, a 20-meter cable showed as 25 meters, and a 40-meter cable
> showed as 50 meters. Since other parts of the diagnostics provided by this
> PHY (e.g., Active Link Cable Diagnostics) require accurate cable
> characterization to provide proper results, this tuning can be implemented
> in a separate patch/interface.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> changes v2:
> - add comments
> - change post silence time to 1000ms

Nice comments, thanks.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew