Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

From: Jaroslav Kysela
Date: Fri Jul 12 2024 - 12:26:04 EST


On 12. 07. 24 15:00, Mark Brown wrote:
On Fri, Jul 12, 2024 at 11:20:05AM +0200, Jaroslav Kysela wrote:
On 12. 07. 24 10:21, Takashi Iwai wrote:

OTOH, longname can be really ugly to read, and it can vary because it
often embeds address or irq numbers in the string.

Capturing that variation is one of the goals - it should mostly be
stable between runs.

If a general name is the goal, how about using shortname instead?

Or use id field, as Jaroslav suggested, but without the card number
suffix; then it's unique among multiple cards.

I prefer this (use only ID field). This string can be also set in the user
space using sysfs/udev, so the administrator may change it if the default is
not ideal.

The trouble with the ID field is that it's too short and seems likely to
create collisions, for example HDA stuff just seems to default to NVidia
for nVidia cards which seems very likely to create collisions if someone
has two graphics cards in their system.

The default IDs are always unique - see snd_card_set_id_no_lock() in sound/core/init.c . Basically, the suffix will follow the device probe order in this case.

Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.