Re: [PATCH v3 1/1] scsi: ufs: core: Support Updating UIC Command Timeout

From: Bart Van Assche
Date: Fri Jul 12 2024 - 13:52:15 EST


On 7/11/24 6:20 PM, Bao D. Nguyen wrote:
Maybe I misunderstood your comment. You probably was concerned about the execution time of param_set_int(val, kp) vs a single assignment instruction 'uic_cmd_timeout = n;', right? If that's the case, I'll update the patch.

I'm concerned about the two conversions yielding different results, e.g.
because of different handling of base prefixes (e.g. 0x) or different
handling of overflows. This patch would be easier to review if the
conversion from string to int only happens once.

Thanks,

Bart.