Re: [PATCH v2] bitmap: Switch from inline to __always_inline

From: Kees Cook
Date: Fri Jul 12 2024 - 14:01:20 EST


On Fri, Jul 12, 2024 at 10:02:55AM -0700, Yury Norov wrote:
> Hi Brian,
>
> Thanks for taking over this!
>
> + Kees Cook for GCC
> [...]
> But I'm not sure about that and don't know how to check what happens
> under the compilers' hood. Can compiler gurus please clarify?

I don't know much about GCC internals. I just ask GCC devs nicely to
help us where they can. :)

> > Subject: [PATCH 1/3] bitmap: switch from inline to __always_inline

We always expected them to be inline, and if we need to hit the
compilers harder with __always_inline, that seems sensible to me.

Reviewed-by: Kees Cook <kees@xxxxxxxxxx>

--
Kees Cook