Re: [net-next PATCH v9 05/11] octeontx2-af: Add packet path between representor and VF

From: Markus Elfring
Date: Fri Jul 12 2024 - 15:52:59 EST


> Current HW, do not support in-built switch which will forward pkts

does? built-in?

How do you think about to avoid any abbreviations for another improved change description?



> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_rep.c

> +void rvu_rep_update_rules(struct rvu *rvu, u16 pcifunc, bool ena)
> +{

> + rvu_switch_enable_lbk_link(rvu, pcifunc, ena);
> + mutex_lock(&mcam->lock);
> + for (entry = 0; entry < max; entry++) {

> + }
> + mutex_unlock(&mcam->lock);
> +}


Under which circumstances would you become interested to apply a construct
like “scoped_guard(mutex, &mcam->lock)”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/cleanup.h#L137

Regards,
Markus