Re: [PATCH 1/2] PM: domains: add device managed version of dev_pm_domain_attach|detach_list()

From: kernel test robot
Date: Fri Jul 12 2024 - 22:43:15 EST


Hi Dikshita,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on rafael-pm/bleeding-edge linus/master v6.10-rc7 next-20240712]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Dikshita-Agarwal/PM-domains-add-device-managed-version-of-dev_pm_domain_attach-detach_list/20240712-135151
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/1720763312-13018-2-git-send-email-quic_dikshita%40quicinc.com
patch subject: [PATCH 1/2] PM: domains: add device managed version of dev_pm_domain_attach|detach_list()
config: x86_64-buildonly-randconfig-001-20240713 (https://download.01.org/0day-ci/archive/20240713/202407131034.zV21FEsV-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240713/202407131034.zV21FEsV-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407131034.zV21FEsV-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/base/power/common.c:288: warning: Function parameter or struct member '_list' not described in 'devm_pm_domain_detach_list'
>> drivers/base/power/common.c:288: warning: expecting prototype for dev_pm_domain_detach_list(). Prototype was for devm_pm_domain_detach_list() instead
>> drivers/base/power/common.c:307: warning: Function parameter or struct member 'dev' not described in 'devm_pm_domain_attach_list'
>> drivers/base/power/common.c:307: warning: Function parameter or struct member 'data' not described in 'devm_pm_domain_attach_list'
>> drivers/base/power/common.c:307: warning: Function parameter or struct member 'list' not described in 'devm_pm_domain_attach_list'


vim +288 drivers/base/power/common.c

278
279 /**
280 * dev_pm_domain_detach_list - devres-enabled version of dev_pm_domain_detach_list.
281 * @list: The list of PM domains to detach.
282 *
283 * This function reverse the actions from devm_pm_domain_attach_list().
284 * it will be invoked during the remove phase from drivers implicitly if driver
285 * uses devm_pm_domain_attach_list() to attach the PM domains.
286 */
287 void devm_pm_domain_detach_list(void *_list)
> 288 {
289 struct dev_pm_domain_list *list = _list;
290
291 dev_pm_domain_detach_list(list);
292 }
293 EXPORT_SYMBOL_GPL(devm_pm_domain_detach_list);
294
295 /**
296 * devm_pm_domain_attach_list - devres-enabled version of dev_pm_domain_attach_list
297 *
298 * NOTE: this will also handle calling devm_pm_domain_detach_list() for
299 * you during remove phase.
300 *
301 * Returns the number of attached PM domains or a negative error code in case of
302 * a failure.
303 */
304 int devm_pm_domain_attach_list(struct device *dev,
305 const struct dev_pm_domain_attach_data *data,
306 struct dev_pm_domain_list **list)
> 307 {
308 int ret, num_pds = 0;
309
310 num_pds = dev_pm_domain_attach_list(dev, data, list);
311
312 ret = devm_add_action_or_reset(dev, devm_pm_domain_detach_list, (void *)list);
313 if (ret)
314 return ret;
315
316 return num_pds;
317 }
318 EXPORT_SYMBOL_GPL(devm_pm_domain_attach_list);
319

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki