Re: [PATCH] ubi: Fix ubi_init() ubiblock_exit() section mismatch

[Zhihao Cheng]

在 2024/7/13 15:35, Richard Weinberger 写道:
> Since ubiblock_exit() is now called from an init function,
> the __exit section no longer makes sense.
>
> Cc: Ben Hutchings <bwh@xxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202407131403.wZJpd8n2-lkp@xxxxxxxxx/
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
>   drivers/mtd/ubi/block.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Looks like that you prefer a simpler fix. Feel fine to add

Reviewed-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>
> diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
> index bf7308e8ec2fe..60d0155be869f 100644
> --- a/drivers/mtd/ubi/block.c
> +++ b/drivers/mtd/ubi/block.c
> @@ -670,7 +670,7 @@ int __init ubiblock_init(void)
>   	return ret;
>   }
>   
> -void __exit ubiblock_exit(void)
> +void ubiblock_exit(void)
>   {
>   	ubi_unregister_volume_notifier(&ubiblock_notifier);
>   	ubiblock_remove_all();