Re: [PATCH] ubi: Fix ubi_init() ubiblock_exit() section mismatch

[Zhihao Cheng]

在 2024/7/13 16:46, Richard Weinberger 写道:
> ----- Ursprüngliche Mail -----
> > Von: "chengzhihao1" <chengzhihao1@xxxxxxxxxx>
> > An: "richard" <richard@xxxxxx>, "linux-mtd" <linux-mtd@xxxxxxxxxxxxxxxxxxx>
> > CC: "linux-kernel" <linux-kernel@xxxxxxxxxxxxxxx>, "Ben Hutchings" <bwh@xxxxxxxxxx>, "kernel test robot" <lkp@xxxxxxxxx>
> > Gesendet: Samstag, 13. Juli 2024 10:16:15
> > Betreff: Re: [PATCH] ubi: Fix ubi_init() ubiblock_exit() section mismatch
>
> > 在 2024/7/13 15:35, Richard Weinberger 写道:
> > > Since ubiblock_exit() is now called from an init function,
> > > the __exit section no longer makes sense.
> > >
> > > Cc: Ben Hutchings <bwh@xxxxxxxxxx>
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > > Closes:
> > > https://lore.kernel.org/oe-kbuild-all/202407131403.wZJpd8n2-lkp@xxxxxxxxx/
> > > Signed-off-by: Richard Weinberger <richard@xxxxxx>
> > > ---
> > >    drivers/mtd/ubi/block.c | 2 +-
> > >    1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Looks like that you prefer a simpler fix. Feel fine to add
>
> Yes, and Ben sent the patch first. :)
>   
> > Reviewed-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>
>
> Thanks for the review!
> And especially thanks for reviewing so many UBI/UBIFS patches,
> I appreciate your help.

You're welcome.
BTW, I have two favors to need your help.
1. Give me some feedbacks about the fsck.ubifs patch series 
[https://patchwork.ozlabs.org/project/linux-mtd/list/?series=409935], 
maybe you have started looking at them. I know it is a huge reviewing 
work, maybe you can start with using, testing or reading the documents.
2. I reported a 
BUG[https://lore.kernel.org/linux-ext4/346993f2-87f6-e20f-8f5a-d19f84c1604c@xxxxxxxxxxxxxxx/T/#m36825671b018880ca17e4c093a4dbfc1b66d5db8] 
recently, please let me know if you have a good solution.

> Thanks,
> //richard
>
> .