Re: [PATCH v9 0/3] iio: pressure: bmp280: Minor cleanup and triggered

[Jonathan Cameron]

On Sun, 30 Jun 2024 22:27:54 +0200
Vasileios Amoiridis <vassilisamir@xxxxxxxxx> wrote:

> On Sun, Jun 30, 2024 at 11:23:42AM +0100, Jonathan Cameron wrote:
> > On Fri, 28 Jun 2024 19:17:23 +0200
> > Vasileios Amoiridis <vassilisamir@xxxxxxxxx> wrote:
> >   
> > > Changes in v9:
> > > 
> > > Patch 1/3:
> > > 	- In bmp580_temp_coeffs, instead of *1000/2^16, now we have *125/2^13
> > > 	  to avoid overflows, as it was proposed.
> > > 	- Type casting to (s64) to temperature read in the read_raw_impl
> > > 	  function was removed as well as it is no longer needed.
> > > 
> > > Patch 3/3:
> > > 	- Renamed "buffer_handler" to "trigger_handler" to keep consistency
> > > 	  with the rest of the drivers.
> > > 	- Added new iio_channel_spec for bmp580 in order to use IIO_LE and
> > > 	  real_bits = 24.
> > > 
> > > v8: https://lore.kernel.org/linux-iio/20240617230540.32325-1-vassilisamir@xxxxxxxxx/  
> > 
> > This seems fine to me now, but I'd like a final 'we didn't break anything' from
> > Adam before i pick it up.  Once bitten, twice shy and all that ;)
> > 
> > J
> >   
> 
> Hi Jonathan,
> 
> Perfect! Let's see what Adam has to say as well.
> Thanks for the very helpful reviews :)
> 
Adam, if you could take a look that would be great.  There is no
huge rush given the merge window opens tomorrow, so this is 6.12 material but
none the less good to tick it off!

Jonathan

> Cheers,
> Vasilis
> 
> >   
> > > 
> > > Vasileios Amoiridis (3):
> > >   iio: pressure: bmp280: Generalize read_*() functions
> > >   iio: pressure: bmp280: Add SCALE, RAW values in channels and
> > >     refactorize them
> > >   iio: pressure: bmp280: Add triggered buffer support
> > > 
> > >  drivers/iio/pressure/Kconfig       |   2 +
> > >  drivers/iio/pressure/bmp280-core.c | 643 +++++++++++++++++++++++++----
> > >  drivers/iio/pressure/bmp280-spi.c  |   8 +-
> > >  drivers/iio/pressure/bmp280.h      |  34 +-
> > >  4 files changed, 589 insertions(+), 98 deletions(-)
> > > 
> > > 
> > > base-commit: 3341d69268accb5294b569ec37e55212a8a28ac5  
> >