Re: [PATCH net-next v2] net: ethernet: lantiq_etop: remove redundant device name setup

From: Andrew Lunn
Date: Sat Jul 13 2024 - 14:03:24 EST


On Sat, Jul 13, 2024 at 07:09:20PM +0200, Aleksander Jan Bajkowski wrote:
> The same name is set when allocating the netdevice structure in the
> alloc_etherdev_mq()->alloc_etherrdev_mqs() function. Therefore, there
> is no need to manually set it.

If this one is not needed:

grep -r "eth%d" *
3com/3c515.c: sprintf(dev->name, "eth%d", unit);
8390/smc-ultra.c: sprintf(dev->name, "eth%d", unit);
8390/wd.c: sprintf(dev->name, "eth%d", unit);
8390/ne.c: sprintf(dev->name, "eth%d", unit);
amd/lance.c: sprintf(dev->name, "eth%d", unit);
atheros/atlx/atl2.c: strcpy(netdev->name, "eth%d"); /* ?? */
cirrus/cs89x0.c: sprintf(dev->name, "eth%d", unit);
dec/tulip/tulip_core.c: strcpy(dev->name, "eth%d"); /* un-hack */
intel/ixgbe/ixgbe_main.c: strcpy(netdev->name, "eth%d");
intel/ixgbevf/ixgbevf_main.c: strcpy(netdev->name, "eth%d");
intel/e100.c: strcpy(netdev->name, "eth%d");
intel/igbvf/netdev.c: strcpy(netdev->name, "eth%d");
intel/e1000e/netdev.c: strscpy(netdev->name, "eth%d", sizeof(netdev->name));
intel/igb/igb_main.c: strcpy(netdev->name, "eth%d");
intel/igc/igc_main.c: strscpy(netdev->name, "eth%d", sizeof(netdev->name));
intel/e1000/e1000_main.c: strcpy(netdev->name, "eth%d");
lantiq_etop.c: strcpy(dev->name, "eth%d");
micrel/ks8842.c: strcpy(netdev->name, "eth%d");
smsc/smc9194.c: sprintf(dev->name, "eth%d", unit);

maybe you can remove all these as well?

Andrew