Re: [PATCH 2/2] selftests/bpf: Change uretprobe syscall number in uprobe_syscall test

From: Google
Date: Mon Jul 15 2024 - 01:47:11 EST


On Fri, 12 Jul 2024 11:27:30 -0700
Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote:

> On Fri, Jul 12, 2024 at 6:53 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> >
> > Fixing the syscall number value.
> >
> > Fixes: 9e7f74e64ae5 ("selftests/bpf: Add uretprobe syscall call from user space test")
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> > ---
> > tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> is this selftest in probes/for-next already? If yes, I'd combine these
> two patches to avoid any bisection problems
>
> but either way
>
> Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>

Thanks, let me pick it to for-next branch.

Thank you,

>
>
> > diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c b/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
> > index c8517c8f5313..bd8c75b620c2 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
> > @@ -216,7 +216,7 @@ static void test_uretprobe_regs_change(void)
> > }
> >
> > #ifndef __NR_uretprobe
> > -#define __NR_uretprobe 463
> > +#define __NR_uretprobe 467
> > #endif
> >
> > __naked unsigned long uretprobe_syscall_call_1(void)
> > --
> > 2.45.2
> >


--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>