Re: [PATCH] clk: qcom: Constify struct freq_tbl

From: Dmitry Baryshkov
Date: Mon Jul 15 2024 - 02:21:34 EST


On Sun, Jul 14, 2024 at 03:01:58PM GMT, Christophe JAILLET wrote:
> 'struct freq_tbl' are not modified in these drivers.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
>
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
> text data bss dec hex filename
> 7595 43696 0 51291 c85b drivers/clk/qcom/mmcc-apq8084.o
>
> After:
> =====
> text data bss dec hex filename
> 9867 41424 0 51291 c85b drivers/clk/qcom/mmcc-apq8084.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> Compile tested-only.
>
> I hope that it can be applied with this single patch because all files are
> in drivers/clk/qcom/.
> ---
> drivers/clk/qcom/gcc-ipq6018.c | 2 +-
> drivers/clk/qcom/gcc-ipq806x.c | 4 +--
> drivers/clk/qcom/gcc-ipq8074.c | 4 +--
> drivers/clk/qcom/gcc-mdm9615.c | 4 +--
> drivers/clk/qcom/gcc-msm8660.c | 4 +--
> drivers/clk/qcom/gcc-msm8960.c | 6 ++--
> drivers/clk/qcom/gcc-msm8994.c | 54 ++++++++++++++++-----------------
> drivers/clk/qcom/gcc-msm8996.c | 2 +-
> drivers/clk/qcom/gcc-msm8998.c | 2 +-
> drivers/clk/qcom/lcc-ipq806x.c | 8 ++---
> drivers/clk/qcom/lcc-msm8960.c | 8 ++---
> drivers/clk/qcom/mmcc-apq8084.c | 50 +++++++++++++++---------------
> drivers/clk/qcom/mmcc-msm8960.c | 30 +++++++++---------
> drivers/clk/qcom/mmcc-msm8974.c | 52 +++++++++++++++----------------
> drivers/clk/qcom/mmcc-msm8994.c | 8 ++---
> drivers/clk/qcom/mmcc-msm8996.c | 8 ++---
> 16 files changed, 123 insertions(+), 123 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

--
With best wishes
Dmitry