Re: [PATCH 2/2] media: qcom: camss: Fix ordering of pm_runtime_enable

[Johan Hovold]

On Sun, Jul 14, 2024 at 11:53:59PM +0100, Bryan O'Donoghue wrote:
> pm_runtime_enable() should happen prior to vfe_get() since vfe_get() calls
> pm_runtime_resume_and_get().

Again, please describe how this manifest itself to users. I see
occasional:

	qcom-camss ac5a000.camss: Failed to power up pipeline: -13

on boot.

> This is a basic race condition that doesn't show up for most users so is
> not widely reported. If you blacklist qcom-camss in modules.d and then
> subsequently modprobe the module post-boot it is possible to reliably show
> this error up.
> 
> Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")

Missing CC-stable here too.

> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

Reported-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
Link: https://lore.kernel.org/lkml/ZoVNHOTI0PKMNt4_@xxxxxxxxxxxxxxxxxxxx/
Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx>

Johan