Re: [PATCH net-next] llc: Constify struct llc_conn_state_trans

From: Simon Horman
Date: Mon Jul 15 2024 - 04:21:11 EST


+ Iwashima-san

On Sun, Jul 14, 2024 at 06:05:56PM +0200, Christophe JAILLET wrote:
> 'struct llc_conn_state_trans' are not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
>
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
> text data bss dec hex filename
> 13923 10896 32 24851 6113 net/llc/llc_c_st.o
>
> After:
> =====
> text data bss dec hex filename
> 21859 3328 0 25187 6263 net/llc/llc_c_st.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>