Re: [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro

[Google]

On Thu, 11 Jul 2024 11:14:20 -0700
Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote:

> On 6/2/24 23:45, Masami Hiramatsu (Google) wrote:
> > On Mon, 3 Jun 2024 11:25:59 +0800
> > "wuqiang.matt" <wuqiang.matt@xxxxxxxxxxxxx> wrote:
> > 
> >> On 2024/6/1 08:31, Jeff Johnson wrote:
> >>> make allmodconfig && make W=1 C=1 reports:
> >>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o
> >>>
> >>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> >>>
> >>> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> >>> ---
> >>>    lib/test_objpool.c | 3 ++-
> >>>    1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/lib/test_objpool.c b/lib/test_objpool.c
> >>> index bfdb81599832..5a3f6961a70f 100644
> >>> --- a/lib/test_objpool.c
> >>> +++ b/lib/test_objpool.c
> >>> @@ -687,4 +687,5 @@ static void __exit ot_mod_exit(void)
> >>>    module_init(ot_mod_init);
> >>>    module_exit(ot_mod_exit);
> >>>    
> >>> -MODULE_LICENSE("GPL");
> >>> \ No newline at end of file
> >>> +MODULE_DESCRIPTION("Test module for lockless object pool");
> >>> +MODULE_LICENSE("GPL");
> >>>
> >>> ---
> >>> base-commit: b050496579632f86ee1ef7e7501906db579f3457
> >>> change-id: 20240531-md-lib-test_objpool-338d937f8666
> >>>
> >>
> >> Looks good to me. Thanks for the update.
> >>
> >> I added Masami Hiramatsu and linux-trace in the loop.
> >>
> >> Reviewed-by: Matt Wu <wuqiang.matt@xxxxxxxxxxxxx>
> > 
> > Thanks, let me pick this to probes/for-next branch.
> Following up since I don't see this in linux-next.
> I'm hoping to have these warnings fixed tree-wide in 6.11.

Oops, sorry, I missed this. Let me try.

Thank you,

> 
> /jeff
> 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>