Re: [PATCH] ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node

[Krzysztof Kozlowski]

On 15/07/2024 10:32, Bingwu Zhang wrote:
> From: Bingwu Zhang <xtexchooser@xxxxxxxx>
> 
> Add pstore node to allow for retrieving crash logs.
> 
> Tested-by: Bingwu Zhang <xtexchooser@xxxxxxxx> # on SM-G9008W (samsung-kltechn)

Tested-by tags are provided by others, not by yourself. It's expected
that you test youro own patches. Drop the tag.

> Signed-off-by: Bingwu Zhang <xtexchooser@xxxxxxxx>
> ---
>  .../qcom-msm8974pro-samsung-klte-common.dtsi    | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> index b5443fd5b425..ff98b9362b0d 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> @@ -126,6 +126,23 @@ led@3 {
>  		};
>  	};
>  
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;

Don't duplicate the nodes, but rather extend via phandle/label. Or at
least drop duplicated properties.

> +
> +		ramoops@3e8e0000 {
> +			compatible = "ramoops";
> +			reg = <0x3e8e0000 0x200000>;
> +
Best regards,
Krzysztof