Re: [PATCH net-next v3 2/2] vsock/virtio: avoid queuing packets when work queue is empty

[Luigi Leonardi]

Hi Stefano,

Thanks for your review!

> On Thu, Jul 11, 2024 at 04:58:47PM GMT, Luigi Leonardi via B4 Relay wrote:
> >From: Luigi Leonardi <luigi.leonardi@xxxxxxxxxxx>
> >
> >Introduce an optimization in virtio_transport_send_pkt:
> >when the work queue (send_pkt_queue) is empty the packet is
>
> Note: send_pkt_queue is just a queue of sk_buff, is not really a work
> queue.
>
> >put directly in the virtqueue increasing the throughput.
>
> Why?
My guess is that is due to the hotpath being faster, there is (potentially) one less
step!
>
> I tested the patch and everything seems to be fine, all my comments are
> minor and style, the code should be fine!
Great, I'll send a v4 addressing all your comments :)

Thanks,
Luigi