Re: [PATCH v5 1/3] dt-bindings: hwmon: Add adt7475 fan/pwm properties

From: Rob Herring (Arm)
Date: Mon Jul 15 2024 - 08:18:19 EST



On Fri, 12 Jul 2024 11:46:12 +1200, Chris Packham wrote:
> Add fan child nodes that allow describing the connections for the
> ADT7475 to the fans it controls. This also allows setting some
> initial values for the pwm duty cycle and frequency.
>
> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> ---
>
> Notes:
> Changes in v5:
> - Use nanoseconds for PWM frequency and duty cycle as per existing
> conventions for PWMs
> - Set flags to 0 in example to match adi,pwm-active-state setting
> Changes in v4:
> - 0 is not a valid frequency value
> Changes in v3:
> - Use the pwm provider/consumer bindings
> Changes in v2:
> - Document 0 as a valid value (leaves hardware as-is)
>
> .../devicetree/bindings/hwmon/adt7475.yaml | 35 ++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)
>

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>