Re: [PATCH] arm64: remove redundant 'if HAVE_ARCH_KASAN' in Kconfig

[Masahiro Yamada]

On Mon, Jul 15, 2024 at 10:29 PM Mark Rutland <mark.rutland@xxxxxxx> wrote:
>
> On Sun, Jul 14, 2024 at 07:58:46PM +0900, Masahiro Yamada wrote:
> > The condition 'select HAVE_ARCH_KASAN' is always true because
> > there is 'select HAVE_ARCH_KASAN' statement above.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
>
> Looks like we forgot to simplify this in commit:
>
>   0383808e4d99ac31 ("arm64: kasan: Reduce minimum shadow alignment and enable 5 level paging")
>
> ... where we began selecting HAVE_ARCH_KASAN unconditionally.


Good point. This may be worth recording in the description.

I will send v2 with a typo fixed.

Thanks.



>
> FWIW:
>
> Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
>
> Mark.
>
> > ---
> >
> >  arch/arm64/Kconfig | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > index c87d16b12e9b..d37cbfc3031e 100644
> > --- a/arch/arm64/Kconfig
> > +++ b/arch/arm64/Kconfig
> > @@ -167,9 +167,9 @@ config ARM64
> >       select HAVE_ARCH_JUMP_LABEL
> >       select HAVE_ARCH_JUMP_LABEL_RELATIVE
> >       select HAVE_ARCH_KASAN
> > -     select HAVE_ARCH_KASAN_VMALLOC if HAVE_ARCH_KASAN
> > -     select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN
> > -     select HAVE_ARCH_KASAN_HW_TAGS if (HAVE_ARCH_KASAN && ARM64_MTE)
> > +     select HAVE_ARCH_KASAN_VMALLOC
> > +     select HAVE_ARCH_KASAN_SW_TAGS
> > +     select HAVE_ARCH_KASAN_HW_TAGS if ARM64_MTE
> >       # Some instrumentation may be unsound, hence EXPERT
> >       select HAVE_ARCH_KCSAN if EXPERT
> >       select HAVE_ARCH_KFENCE
> > --
> > 2.43.0
> >
> >
>


-- 
Best Regards
Masahiro Yamada