Re: [PATCH 1/2] radix tree test suite: include kconfig.h with incomplete path

From: Liam R. Howlett
Date: Mon Jul 15 2024 - 12:18:15 EST


* Wei Yang <richard.weiyang@xxxxxxxxx> [240712 03:42]:
> The include path indicates it is the kconfig.h in tools/include/linux.
>
> Let's use the same format as others for better reading.

nack

This change stops using tools/testing/radix-tree/generated/autoconf.h
which is included from kconfig.h.

If you add an #error to that generated/autoconf.h header, then you will
see it will build with your change, but fails with the existing code.

So this is not equivalent.

>
> Signed-off-by: Wei Yang <richard.weiyang@xxxxxxxxx>
> CC: "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>
> CC: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> ---
> tools/testing/radix-tree/linux/kernel.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/radix-tree/linux/kernel.h b/tools/testing/radix-tree/linux/kernel.h
> index c0a2bb785b92..fab6f47a9472 100644
> --- a/tools/testing/radix-tree/linux/kernel.h
> +++ b/tools/testing/radix-tree/linux/kernel.h
> @@ -11,7 +11,7 @@
> #include <linux/err.h>
> #include <linux/bitops.h>
> #include <linux/log2.h>
> -#include "../../../include/linux/kconfig.h"
> +#include <linux/kconfig.h>
>
> #define printk printf
> #define pr_err printk
> --
> 2.34.1
>