Re: [PATCH v2] blk-cgroup: Replace u64_sync with blkg_stat_lock for stats update

From: tj@xxxxxxxxxx
Date: Mon Jul 15 2024 - 13:21:41 EST


Hello,

On Mon, Jul 15, 2024 at 07:15:24AM +0000, Boy Wu (吳勃誼) wrote:
> I think I get your idea. You want to replace all the u64 sync for
> iostat. However, I have one question: why use blkg_stat_lock instead of
> adding a spin lock for each iostat like iostat.spinlock? We don't need
> to lock between updating different iostats, but only lock when updating
> the same iostat.

Oh yeah, that'd be even better.

Thanks.

--
tejun