Re: [PATCH] workqueue: Remove unneeded lockdep_assert_cpus_held()

From: Tejun Heo
Date: Mon Jul 15 2024 - 14:23:23 EST


Hello,

On Tue, Jul 16, 2024 at 01:29:31AM +0800, Lai Jiangshan wrote:
> @@ -6906,7 +6898,6 @@ static int wq_affn_dfl_set(const char *val, const struct kernel_param *kp)
> if (affn == WQ_AFFN_DFL)
> return -EINVAL;
>
> - cpus_read_lock();
> mutex_lock(&wq_pool_mutex);
>
> wq_affn_dfl = affn;
> @@ -6917,7 +6908,6 @@ static int wq_affn_dfl_set(const char *val, const struct kernel_param *kp)
> }
>
> mutex_unlock(&wq_pool_mutex);
> - cpus_read_unlock();

This part isn't explained in the patch description. Can you separate it out
to a separate patch or add description in this patch?

Thanks.

--
tejun