Re: [PATCH v3 5/8] timers/migration: Read childmask and parent pointer in a single place

[Frederic Weisbecker]

Le Mon, Jul 01, 2024 at 12:18:41PM +0200, Anna-Maria Behnsen a écrit :
> Reading the childmask and parent pointer is required when propagating
> changes through the hierarchy. At the moment this reads are spread all over
> the place which makes it harder to follow.
> 
> Move those reads to a single place to keep code clean.
> 
> Signed-off-by: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx>
> ---
>  kernel/time/timer_migration.c | 20 +++++---------------
>  1 file changed, 5 insertions(+), 15 deletions(-)
> 
> diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c
> index b4391abfb4a9..a681cf89910e 100644
> --- a/kernel/time/timer_migration.c
> +++ b/kernel/time/timer_migration.c
> @@ -535,6 +535,7 @@ static void __walk_groups(up_f up, struct tmigr_walk *data,
>  
>  		child = group;
>  		group = group->parent;
> +		data->childmask = group->childmask;

Should be "data->childmask = child->childmask;" ?

>  	} while (group);
>  }

Thanks.