Re: [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash_info()

From: Christophe JAILLET
Date: Mon Jul 15 2024 - 16:25:01 EST


Le 15/07/2024 à 18:01, Jakub Kicinski a écrit :
On Sat, 13 Jul 2024 15:18:42 +0200 Markus Elfring wrote:
Single characters (line breaks) should be put into a sequence.
Thus use the corresponding function “seq_putc”.

This issue was transformed by using the Coccinelle software.

I prefer to only merge trivial changes like this if maintainer
indicates their support by acking them. Since the merge window
has opened we can't wait and see so I'm marking this patch and
your pktgen patch as deferred.



Hi Jakub,

Most of the time, this kind of modification is useless because it is already done by the compiler, see [1].

CJ

[1]: https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/seq_file.h#L123