Re: [PATCH net-next v17 06/14] net: Add struct kernel_ethtool_ts_info

From: Jacob Keller
Date: Mon Jul 15 2024 - 19:41:30 EST




On 7/9/2024 6:53 AM, Kory Maincent wrote:
> In prevision to add new UAPI for hwtstamp we will be limited to the struct
> ethtool_ts_info that is currently passed in fixed binary format through the
> ETHTOOL_GET_TS_INFO ethtool ioctl. It would be good if new kernel code
> already started operating on an extensible kernel variant of that
> structure, similar in concept to struct kernel_hwtstamp_config vs struct
> hwtstamp_config.
>
> Since struct ethtool_ts_info is in include/uapi/linux/ethtool.h, here
> we introduce the kernel-only structure in include/linux/ethtool.h.
> The manual copy is then made in the function called by ETHTOOL_GET_TS_INFO.
>
> Acked-by: Shannon Nelson <shannon.nelson@xxxxxxx>
> Acked-by: Alexandra Winter <wintera@xxxxxxxxxxxxx>
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>

Also for the Intel driver changes specifically:

Acked-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>