Re: [PATCH v3] thermal: core: Call monitor_thermal_zone() if zone temperature is invalid

From: Stefan Lippers-Hollmann
Date: Mon Jul 15 2024 - 19:49:02 EST


Hi

On 2024-07-15, Rafael J. Wysocki wrote:
> On Mon, Jul 15, 2024 at 2:54 PM Stefan Lippers-Hollmann <s.l-h@xxxxxx> wrote:
> > On 2024-07-15, Rafael J. Wysocki wrote:
> > > On Mon, Jul 15, 2024 at 11:09 AM Daniel Lezcano
> > > <daniel.lezcano@xxxxxxxxxx> wrote:
> > > > On 15/07/2024 06:45, Eric Biggers wrote:
> > > > > On Thu, Jul 04, 2024 at 01:46:26PM +0200, Rafael J. Wysocki wrote:
> > > > >> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
[...]
> > Silencing the warnings is already a big improvement - and that patch
> > works to this extent for me with an ax200, thanks.
>
> So attached is a patch that should avoid enabling the thermal zone
> when it is not ready for use in the first place, so it should address
> both the message and the useless polling.
>
> I would appreciate giving it a go (please note that it hasn't received
> much testing so far, though).

Sadly this patch doesn't seem to help:

$ dmesg | grep -e iwlwifi -e thermal
[ 0.113700] thermal_sys: Registered thermal governor 'fair_share'
[ 0.113700] thermal_sys: Registered thermal governor 'bang_bang'
[ 0.113700] thermal_sys: Registered thermal governor 'step_wise'
[ 0.113700] thermal_sys: Registered thermal governor 'user_space'
[ 0.113700] thermal_sys: Registered thermal governor 'power_allocator'
[ 3.885485] iwlwifi 0000:04:00.0: enabling device (0140 -> 0142)
[ 3.888462] iwlwifi 0000:04:00.0: Detected crf-id 0x3617, cnv-id 0x100530 wfpm id 0x80000000
[ 3.888471] iwlwifi 0000:04:00.0: PCI dev 2723/0084, rev=0x340, rfid=0x10a100
[ 3.892720] iwlwifi 0000:04:00.0: TLV_FW_FSEQ_VERSION: FSEQ Version: 89.3.35.37
[ 3.994292] iwlwifi 0000:04:00.0: loaded firmware version 77.a20fb07d.0 cc-a0-77.ucode op_mode iwlmvm
[ 4.383879] iwlwifi 0000:04:00.0: Detected Intel(R) Wi-Fi 6 AX200 160MHz, REV=0x340
[ 4.513229] iwlwifi 0000:04:00.0: Detected RF HR B3, rfid=0x10a100
[ 4.578828] iwlwifi 0000:04:00.0: base HW address: 94:e6:f7:XX:XX:XX
[ 4.592597] thermal thermal_zone2: failed to read out thermal zone (-61)
[ 4.604651] iwlwifi 0000:04:00.0 wlp4s0: renamed from wlan0
[ 4.849442] thermal thermal_zone2: failed to read out thermal zone (-61)
[ 5.105488] thermal thermal_zone2: failed to read out thermal zone (-61)
[ 5.361470] thermal thermal_zone2: failed to read out thermal zone (-61)
[ 5.618458] thermal thermal_zone2: failed to read out thermal zone (-61)
[ 5.873428] thermal thermal_zone2: failed to read out thermal zone (-61)
[ 6.129429] thermal thermal_zone2: failed to read out thermal zone (-61)
[ 6.385446] thermal thermal_zone2: failed to read out thermal zone (-61)
[ 6.641695] thermal thermal_zone2: failed to read out thermal zone (-61)

Regards
Stefan Lippers-Hollmann

P.S.: I've now also noticed the same issue on a raptor-lake system with AX201.