Re: [PATCH v2] arm64: remove redundant 'if HAVE_ARCH_KASAN' in Kconfig

From: Anshuman Khandual
Date: Tue Jul 16 2024 - 00:19:32 EST




On 7/16/24 00:58, Masahiro Yamada wrote:
> Since commit 0383808e4d99 ("arm64: kasan: Reduce minimum shadow
> alignment and enable 5 level paging"), HAVE_ARCH_KASAN is always 'y'.
>
> The condition 'if HAVE_ARCH_KASAN' is always met.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Reviewed-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>

> ---
>
> Changes in v2:
> - update description
> - add reviewed-by and acked-by
>
> arch/arm64/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index c87d16b12e9b..d37cbfc3031e 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -167,9 +167,9 @@ config ARM64
> select HAVE_ARCH_JUMP_LABEL
> select HAVE_ARCH_JUMP_LABEL_RELATIVE
> select HAVE_ARCH_KASAN
> - select HAVE_ARCH_KASAN_VMALLOC if HAVE_ARCH_KASAN
> - select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN
> - select HAVE_ARCH_KASAN_HW_TAGS if (HAVE_ARCH_KASAN && ARM64_MTE)
> + select HAVE_ARCH_KASAN_VMALLOC
> + select HAVE_ARCH_KASAN_SW_TAGS
> + select HAVE_ARCH_KASAN_HW_TAGS if ARM64_MTE
> # Some instrumentation may be unsound, hence EXPERT
> select HAVE_ARCH_KCSAN if EXPERT
> select HAVE_ARCH_KFENCE