Re: [PATCH] arm64: dts: qcom: sa8775p: Mark APPS and PCIE SMMUs as DMA coherent

[Qingqing Zhou]

Hi Mani,
Thanks for reviewing, do you mean to post a new patch which adds "Fixes:" tags and "cc: stable@xxxxxxxxxxxxxxx"?

在 7/16/2024 2:05 PM, Manivannan Sadhasivam 写道:
> On Tue, Jul 16, 2024 at 02:00:15PM +0800, Qingqing Zhou wrote:
>>
>>
>> 在 7/16/2024 2:14 AM, Andrew Halaney 写道:
>>> On Mon, Jul 15, 2024 at 12:46:49PM GMT, Qingqing Zhou wrote:
>>>> The SMMUs on sa8775p are cache-coherent. GPU SMMU is marked as such,
>>>> mark the APPS and PCIE ones as well.
>>>>
>>>> Signed-off-by: Qingqing Zhou <quic_qqzhou@xxxxxxxxxxx>
>>>
>>> I think this deserves a Fixes tag as well, not treating it as
>>> dma-coherent is a bug and can lead to difficult to debug errors based on
>>> a quick search through lkml.
>>>
>>> Thanks,
>>> Andrew
>>>
>>
>> Andrew, thanks for your review comments, do you mean to add below two lines?
>> Fixes: 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride")
>> Fixes: 2dba7a613a6e ("arm64: dts: qcom: sa8775p: add the pcie smmu node")
>>
> 
> Yes, looks to be it. With the tags added,
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> 
> And CC stable if the offending commits went into any stable kernels.
> 
> - Mani
>