Re: [PATCH v2 32/60] i2c: mv64xxx: reword according to newest specification

From: Gregory CLEMENT
Date: Tue Jul 16 2024 - 04:41:45 EST


Hello Andi,

> Hi Wolfram,
>
>> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
>> index dc160cbc3155..29f94efedf60 100644
>> --- a/drivers/i2c/busses/i2c-mv64xxx.c
>> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
>> @@ -89,8 +89,8 @@ enum {
>> MV64XXX_I2C_STATE_WAITING_FOR_RESTART,
>> MV64XXX_I2C_STATE_WAITING_FOR_ADDR_1_ACK,
>> MV64XXX_I2C_STATE_WAITING_FOR_ADDR_2_ACK,
>> - MV64XXX_I2C_STATE_WAITING_FOR_SLAVE_ACK,
>> - MV64XXX_I2C_STATE_WAITING_FOR_SLAVE_DATA,
>> + MV64XXX_I2C_STATE_WAITING_FOR_TARGET_ACK,
>> + MV64XXX_I2C_STATE_WAITING_FOR_TARGET_DATA,
>> };
>
> OK, I managed to check and I couldn't find any definition about
> the driver's state.

I apologize for responding late to your previous request.

Out of curiosity, how did you manage to check it? Was it by referring to
the Marvell datasheet pointed in the Documentation, or did you use
another method?

Gregory


>
> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
>
> Thanks,
> Andi