Re: [PATCH v2] perf docs: Mark the Android document as obsolete

[James Clark]

On 15/07/2024 6:17 pm, Ian Rogers wrote:
> On Mon, Jul 15, 2024 at 7:34 AM Leo Yan <leo.yan@xxxxxxx> wrote:
> [snip]
> > +Android NDK compilation is deprecated and no longer supported.
>
> I think this is objectively worse than just removing the file. It is

Objectively worse is a bit strong. There was some discussion on the 
previous version about the reasoning, but the point is to leave keywords 
so that someone re-writing the NDK docs in the future can find it and 
then the history will be preserved rather than putting it in a new file 
with a new name. Or even someone wondering why their build command 
doesn't work has at least something documented about it, even as a negative.

Of course this all depends on whether we decide the Android build 
_should_ be working or not which looks like is also being discussed here.

> likely the perf tool can build with clang/LLVM, I do it every day, and
> the special case for Android is likely more about the libc (aka
> bionic) which gradually over time has been becoming more full fat -
> perhaps we need to carry somethings in tools/include for missing
> definitions, but we build with musl and that's a PITA in this regard,
> we've also been reducing the tools/include dependencies for perf trace
> beauty support. We don't use ifuncs in the perf tool (Android's
> linker/loader historically hasn't supported these) and the weak symbol
> games should be okay and something I aspire to make less in the perf
> tool over time. As Android uses Linux then it should work and should
> be supported.
>
> Thanks,
> Ian