Re: [PATCH net] tipc: Return non-zero value from tipc_udp_addr2str() on error

[Paolo Abeni]

On 7/16/24 09:45, Shigeru Yoshida wrote:
> On Tue, 16 Jul 2024 07:35:50 +0000, Tung Nguyen wrote:
> > > net/tipc/udp_media.c | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index b849a3d133a0..439f75539977 100644
> > > --- a/net/tipc/udp_media.c
> > > +++ b/net/tipc/udp_media.c
> > > @@ -135,8 +135,11 @@ static int tipc_udp_addr2str(struct tipc_media_addr *a, char *buf, int size)
> > >                 snprintf(buf, size, "%pI4:%u", &ua->ipv4, ntohs(ua->port));
> > >         else if (ntohs(ua->proto) == ETH_P_IPV6)
> > >                 snprintf(buf, size, "%pI6:%u", &ua->ipv6, ntohs(ua->port));
> > > -       else
> > > +       else {
> > >                 pr_err("Invalid UDP media address\n");
> > > +               return 1;
> > Please use -EINVAL instead.
>
> Other addr2str functions like tipc_eth_addr2str() use 1, so I followed
> convention. But -EINVAL is more appropriate, as you say.

I think that consistency with other tipc helpers here would be more 
appropriate: IMHO no need to send a v2.

@Tung: please trim your replies to only include the relevant quoted text 
and fix your configuration to avoid inserting the long trailer, quite 
unsuitable for messages sent to a public ML.

Thanks,

Paolo