Re: [PATCH] ASoC: SOF: imx8m: Fix DSP control regmap retrieval

[Iuliana Prodan]

On 7/15/2024 6:16 PM, Daniel Baluta (OSS) wrote:
> From: Daniel Baluta <daniel.baluta@xxxxxxx>
>
> According to Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> fsl,dsp-ctrl is a phandle to syscon block so we need to use correct
> function to retrieve it.
>
> Currently there is no SOF DSP DTS merged into mainline so there is no
> need to support the old way of retrieving the dsp control node.
>
> Fixes: 9ba23717b292 ("ASoC: SOF: imx8m: Implement DSP start")
> Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx>


Reviewed-by: Iuliana Prodan <iuliana.prodan@xxxxxxx>


Thanks,
Iulia
> ---
>   sound/soc/sof/imx/imx8m.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/imx/imx8m.c b/sound/soc/sof/imx/imx8m.c
> index 1c7019c3cbd38..cdd1e79ef9f6a 100644
> --- a/sound/soc/sof/imx/imx8m.c
> +++ b/sound/soc/sof/imx/imx8m.c
> @@ -234,7 +234,7 @@ static int imx8m_probe(struct snd_sof_dev *sdev)
>   	/* set default mailbox offset for FW ready message */
>   	sdev->dsp_box.offset = MBOX_OFFSET;
>   
> -	priv->regmap = syscon_regmap_lookup_by_compatible("fsl,dsp-ctrl");
> +	priv->regmap = syscon_regmap_lookup_by_phandle(np, "fsl,dsp-ctrl");
>   	if (IS_ERR(priv->regmap)) {
>   		dev_err(sdev->dev, "cannot find dsp-ctrl registers");
>   		ret = PTR_ERR(priv->regmap);