Re: [RFC PATCH bpf-next 3/3] bpftool: add document for net attach/detach on tcx subcommand

[Quentin Monnet]

2024-07-15 12:37 UTC+0100 ~ Tao Chen <chen.dylane@xxxxxxxxx>
> This commit adds sample output for net attach/detach on
> tcx subcommand.
> 
> Signed-off-by: Tao Chen <chen.dylane@xxxxxxxxx>
> ---
>  .../bpf/bpftool/Documentation/bpftool-net.rst | 22 ++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/bpf/bpftool/Documentation/bpftool-net.rst b/tools/bpf/bpftool/Documentation/bpftool-net.rst
> index 348812881297..64de7a33f176 100644
> --- a/tools/bpf/bpftool/Documentation/bpftool-net.rst
> +++ b/tools/bpf/bpftool/Documentation/bpftool-net.rst
> @@ -29,7 +29,7 @@ NET COMMANDS
>  | **bpftool** **net help**
>  |
>  | *PROG* := { **id** *PROG_ID* | **pinned** *FILE* | **tag** *PROG_TAG* | **name** *PROG_NAME* }
> -| *ATTACH_TYPE* := { **xdp** | **xdpgeneric** | **xdpdrv** | **xdpoffload** }
> +| *ATTACH_TYPE* := { **xdp** | **xdpgeneric** | **xdpdrv** | **xdpoffload** | **tcxingress** | **tcxegress** }
>  
>  DESCRIPTION
>  ===========
> @@ -69,6 +69,8 @@ bpftool net attach *ATTACH_TYPE* *PROG* dev *NAME* [ overwrite ]
>      **xdpgeneric** - Generic XDP. runs at generic XDP hook when packet already enters receive path as skb;
>      **xdpdrv** - Native XDP. runs earliest point in driver's receive path;
>      **xdpoffload** - Offload XDP. runs directly on NIC on each packet reception;
> +    **tcxingress** - Ingress TC. runs on ingress net traffic;
> +    **tcxegress** - Egress TC. runs on egress net traffic;


I'd keep "TCX" rather than "TC" in the docs, please, to avoid confusion
with programs attached to clsact qdiscs, for example.