Re: [PATCH v3 2/2] i2c: piix4: Register SPDs

From: Andi Shyti
Date: Tue Jul 16 2024 - 13:46:55 EST


Hi Thomas,

On Fri, Jul 12, 2024 at 02:53:49PM GMT, Wolfram Sang wrote:
> > Only the first 8 slots are supported. If the system has more,
> > then these will not be visible.
> >
> > The AUX bus can not be probed as on some platforms it reports all
> > devices present and all reads return "0".
> > This would allow the ee1004 to be probed incorrectly.
>
> I think this information would also be helpful as a comment above the
> code. But to allow this series to be applied now, I think an incremental
> patch will do. With Heiner's ack, I think this can go in now.

I agree with Wolfram here. Are you up for a v4 or do you want me
to add the comment while pushing?

Andi